8000 Make symfony/thanks a suggestion rather than a hard requirement by pfrenssen · Pull Request #3789 · hechoendrupal/drupal-console · GitHub
[go: up one dir, main page]

Skip to content

Make symfony/thanks a suggestion rather than a hard requirement #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2018

Conversation

pfrenssen
Copy link
Contributor

Fix for #3788

@nicolas-grekas
Copy link
Contributor

This doesn't provide the same experience at all.
symfony/thanks is a requirement to the experience the authors of drupal-console want to provide out of the box. Thus it belongs to "require". I understand that you have a different definition of what "require" means, but there is nothing anywhere that makes your definition more accurate than this definition given here: a requirement to the experience. That's a great thing.

@dkarlovi
Copy link

Perhaps a better project to provide that experience would be Composer? This avoids needing to do it for each and every project separately.

@nicolas-grekas
Copy link
Contributor

@dkarlovi see symfony/thanks#35

@dkarlovi
Copy link

@nicolas-grekas yeah, I've seen that issue / tweet before. My point is, if Composer doesn't want to have it be part of their default experience (where it IMO makes way more sense), why should random projects?

Not trying to imply the intention is bad in any way, on the contrary. Just think that adding a Composer plugin as a base requirement to random projects is not a good way forward from a technical standpoint.

@nicolas-grekas
Copy link
Contributor
nicolas-grekas commented Feb 16, 2018

Composer doesn't want to have it be part of their default experience

that's certainly not the reason why this is not in Composer. The only reason that is in this tweet is the maintenance burden this would create on Composer. That's a perfectly valid point. I'm way more interested in maintaining this plugin myself, so that Jordi and Nils can focus their time on core Composer features.

@dkarlovi
Copy link

maintenance burden this would create on Composer

That's "Composer doesn't want it" said in a different way. 😄

How do you reconcile advocating to add this here as require while Symfony doesn't require-dev code it actually references? Seems like a double standard.

Anyway, I understand you're on a mission to get this across (and IMO it a valuable cause), but still think there's got to be a better way to do this.

@davereid
Copy link

There's no way to disable the message. I'm seeing it every time that composer update pulls in new packages, and for a large project that is often. I get it, but now I have no way to NOT see it.

8000
@jmolivas jmolivas added this to the 1.6.1 milestone Feb 21, 2018
@jmolivas jmolivas merged commit 31f333c into hechoendrupal:master Feb 21, 2018
@jmolivas
Copy link
Member

@pfrenssen Thanks for your contribution, your PR was merged. This will be included in the next release.

@pfrenssen
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0