-
-
Notifications
You must be signed in to change notification settings - Fork 554
Make symfony/thanks a suggestion rather than a hard requirement #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make symfony/thanks a suggestion rather than a hard requirement #3789
Conversation
This doesn't provide the same experience at all. |
Perhaps a better project to provide that experience would be Composer? This avoids needing to do it for each and every project separately. |
@nicolas-grekas yeah, I've seen that issue / tweet before. My point is, if Composer doesn't want to have it be part of their default experience (where it IMO makes way more sense), why should random projects? Not trying to imply the intention is bad in any way, on the contrary. Just think that adding a Composer plugin as a base requirement to random projects is not a good way forward from a technical standpoint. |
that's certainly not the reason why this is not in Composer. The only reason that is in this tweet is the maintenance burden this would create on Composer. That's a perfectly valid point. I'm way more interested in maintaining this plugin myself, so that Jordi and Nils can focus their time on core Composer features. |
That's "Composer doesn't want it" said in a different way. 😄 How do you reconcile advocating to add this here as Anyway, I understand you're on a mission to get this across (and IMO it a valuable cause), but still think there's got to be a better way to do this. |
There's no way to disable the message. I'm seeing it every time that composer update pulls in new packages, and for a large project that is often. I get it, but now I have no way to NOT see it. |
@pfrenssen Thanks for your contribution, your PR was merged. This will be included in the next release. |
Thanks! |
Fix for #3788