8000 Adding event handler support for onClick in legend by nielsvanzon · Pull Request #24 · haster/java-chartjs · GitHub
[go: up one dir, main page]

Skip to content

Adding event handler support for onClick in legend#24

Merged
haster merged 3 commits intohaster:masterfrom
topicusonderwijs:event-handlers
Oct 2, 2021
Merged

Adding event handler support for onClick in legend#24
haster merged 3 commits intohaster:masterfrom
topicusonderwijs:event-handlers

Conversation

@nielsvanzon
Copy link
Contributor

No description provided.

@papegaaij
Copy link
Contributor

This PR implement the onClick event handler (issue #20 ) for legend items. The same code can be used to add other event handlers.

In addition, this PR disables the stylesheet injection performed by chartjs and replaces it with a proper stylesheet included via Wicket. This makes it possible to use chartjs with a strict CSP.

@haster
Copy link
Owner
haster commented Jun 21, 2020

Nice! I have just upgraded ChartJs and noticed the CSS as well there. I'll merge this, thanks!

@haster haster merged commit 0fd44b8 into haster:master Oct 2, 2021
@nielsvanzon
Copy link
Contributor Author

woot, it got merged! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0