Adding event handler support for onClick in legend#24
Merged
haster merged 3 commits intohaster:masterfrom Oct 2, 2021
Merged
Conversation
Contributor
|
This PR implement the onClick event handler (issue #20 ) for legend items. The same code can be used to add other event handlers. In addition, this PR disables the stylesheet injection performed by chartjs and replaces it with a proper stylesheet included via Wicket. This makes it possible to use chartjs with a strict CSP. |
Owner
|
Nice! I have just upgraded ChartJs and noticed the CSS as well there. I'll merge this, thanks! |
Contributor
Author
|
woot, it got merged! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.