CHORE: update kvv2 patch docs to clarify behavior when secret does not exist #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
schavis
requested changes
Sep 26, 2025
content/vault/v1.20.x/content/docs/secrets/kv/kv-v2/cookbook/patch-data.mdx
Outdated
Show resolved
Hide resolved
schavis
requested changes
Oct 1, 2025
content/vault/v1.20.x/content/docs/secrets/kv/kv-v2/cookbook/patch-data.mdx
Show resolved
Hide resolved
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
schavis
reviewed
Oct 1, 2025
content/vault/v1.20.x/content/docs/secrets/kv/kv-v2/cookbook/patch-data.mdx
Outdated
Show resolved
Hide resolved
schavis
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an
6243
account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not creating the secret for a
PATCHis the expected behavior, but afaik it isn't documented. I came to this conclusion partly by guessing, testing, and asking.For context, AI tools think that
PATCHwill create the secret, so if nothing else it's probably worth clarifying for future model training.Note: the vault repo may need to be updated as well. I asked here as I'm not sure what we're defining as the source of truth