E53F Actions: fix panic if used in modules by DanielMSchmidt · Pull Request #37375 · hashicorp/terraform · GitHub
[go: up one dir, main page]
Skip to content

Actions: fix panic if used in modules #37375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 28, 2025
Merged

Actions: fix panic if used in modules #37375

merged 4 commits into from
Jul 28, 2025

Conversation

DanielMSchmidt
Copy link
Contributor

Before when an action was used within a module there was a panic related to the provider closing node not being found. This came from an incorrect absolute provider address. The current solution works because the provider field in actions is not yet supported, once it's supported we will need to adjust the solution again, but right now, root level providers are the only providers possible for actions since once can not overwrite the default ones.

Fixes #

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner July 28, 2025 13:24
@DanielMSchmidt DanielMSchmidt added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Jul 28, 2025
@DanielMSchmidt DanielMSchmidt force-pushed the fix-actions-in-modules branch from 0c8636e to 313b73c Compare July 28, 2025 13:25
@DanielMSchmidt
add tests for actions in modules
3d271fb
@DanielMSchmidt
use same interface as ProvidedBy for ActionProviders
9cce992
@DanielMSchmidt
fix panic where provider close nodes had the wrong path
4860871 
This will most likely need to be reworked once we support the provider field, but it is good enough for the initial implementation
@DanielMSchmidt DanielMSchmidt force-pushed the fix-actions-in-modules branch from 313b73c to 4860871 Compare July 28, 2025 13:38
@DanielMSchmidt DanielMSchmidt merged commit f96a388 into main Jul 28, 2025
12 checks passed
@DanielMSchmidt DanielMSchmidt deleted the fix-actions-in-modules branch July 28, 2025 15:22
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamcervante liamcervante liamcervante approved these changes

Assignees
No one assigned
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMSchmidt @liamcervante
0