build(deps): bump github.com/go-git/go-git/v5 from 5.4.2 to 5.5.1 #82
Conversation
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.4.2 to 5.5.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.4.2...v5.5.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
windows-latest test failure looks intermittent: rerunning |
|
Failed again. Apparently the This may be neither here nor there, but interesting to note that hashicorp/go-getter doesn't use https://github.com/go-git/go-git: https://github.com/hashicorp/go-getter/blob/main/get_git.go#L26 Not sure if it's worth reviewing this decision depending on our expectations of the hc-install environment. cc @radeksimko if you have a strong opinion about this, please make an issue, otherwise I will do so later. |
|
@kmoe I originally thought it's resource (memory) usage related #81 (comment) but I may be wrong tbh. It's mostly theory based on:
It's still hard to believe that we'd consume all 7GB of RAM, but I also don't have the confidence to rule it out. I was planning to write and run some benchmarks and/or to reproduce it in a Windows VM, but I haven't had the chance to try either yet. |
|
@kmoe Some findings from my local Windows VM, which confirm your theory about MinGW. 😄 Testing > go test ./...
# runtime/cgo
cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in %PATH%
ok github.com/hashicorp/hc-install (cached)
FAIL github.com/hashicorp/hc-install/build [build failed]> go env
# ...
set CGO_ENABLED=1
# ...Using the same default settings/configuration (w/ CGO enabled), the The easy fix here could be just claiming no support for CGO and adding the corresponding variable to the CI runs, but I'd still like to reproduce the original problem - i.e. install gcc (or its equivalent) in my Windows VM and understand why it's happening. |
|
btw. This problem was likely introduced in go-git/go-git#618 and there was a related PR which fixed similar problem when CGO is disabled: |
|
After 😑 I'm kind of clueless at this point honestly. It would be great if
None of these are ideal, but starting with the first one may not hurt. |
|
Looking more closely at the upstream changes in go-git and https://github.com/pjbgf/sha1cd it appears that it does have some reasonable fallbacks for non-CGO environments. My understanding of the problem is that making CGO work on Windows would be struggle in general, and introduction of a CGO dependency, in combination w/ Therefore I am inclined to go for the "easy fix" of adding @kmoe Any objections to this resolution? |
|
Raised a question upstream in go-git/go-git#637 |
|
Superseded by #84. |
Bumps github.com/go-git/go-git/v5 from 5.4.2 to 5.5.1.
Release notes
Sourced from github.com/go-git/go-git/v5's releases.
Commits
736622f.github: test, remove coverallse43edeeMerge pull request #617 from doxsch/616-update-ssh-agent-to-masterf62ac39Merge pull request #625 from pjbgf/bump-sha1cd-nocgoc7050e7Merge pull request #623 from pjbgf/empty-commit08db65ffix: Upgrade github.com/xanzy/ssh-agent to v0.3.3 to fix panica513415Return error instead of creating empty commits223e732build: Bump github.com/pjbgf/sha1cd to v0.2.3a0b612abuild: Add CI check for CGO_ENABLED=03e07c50Merge pull request #620 from fluxcd/update-depsf2d68c4build: bump git workflow to Go 1.19Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)