Merged
Conversation
Collaborator
|
I don’t think it should have been necessary to bump the major number. If an interface implements send_periodic method directly, everything should work just like it did before, right? |
Collaborator
|
The changes to the mesaage class also break comparability in some ways. |
Codecov Report
@@ Coverage Diff @@
## develop #437 +/- ##
==========================================
+ Coverage 62.5% 62.5% +<.01%
==========================================
Files 55 55
Lines 4656 4657 +1
==========================================
+ Hits 2910 2911 +1
Misses 1746 1746 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So to use semantic versioning properly we need to bump the major version when our api changes in a backwards incompatible way.
The changes to the BusABC requiring custom backends to now implement
_send_periodic_internal(not to mention all the other changes in the changelog) made me think we should be releasing 3.0 instead of 2.3