8000 Remove spaces from setup.py version specifiers by hardbyte · Pull Request #432 · hardbyte/python-can · GitHub
[go: up one dir, main page]

Skip to content

Remove spaces from setup.py version specifiers#432

Merged
hardbyte merged 1 commit intodevelopfrom
fix-dependency-specifications
Sep 28, 2018
Merged

Remove spaces from setup.py version specifiers#432
hardbyte merged 1 commit intodevelopfrom
fix-dependency-specifications

Conversation

@hardbyte
Copy link
Owner

Suggested fix for #431

@hardbyte hardbyte requested a review from felixdivo September 28, 2018 08:15
Copy link
Collaborator
@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the space I mentioned inline, this looks good.

python_requires=">=2.7,!=3.0,!=3.1,!=3.2,!=3.3",
install_requires=[
'wrapt ~= 1.10', 'typing', 'windows-curses;platform_system=="Windows"',
'wrapt~= 1.10', 'typing', 'windows-curses;platform_system=="Windows"',
Copy link
Collaborator
@felixdivo felixdivo Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a space right before 1.10.

@felixdivo felixdivo added this to the 2.3 Release milestone Sep 28, 2018
@hardbyte hardbyte merged commit 1110ac3 into develop Sep 28, 2018
@hardbyte hardbyte deleted the fix-dependency-specifications branch September 28, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0