Use uniform line endings across repository#419
Merged
hardbyte merged 2 commits intohardbyte:developfrom Sep 21, 2018
cottsay:dos2unix
Merged
Use uniform line endings across repository#419hardbyte merged 2 commits intohardbyte:developfrom cottsay:dos2unix
hardbyte merged 2 commits intohardbyte:developfrom
cottsay:dos2unix
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #419 +/- ##
========================================
Coverage 61.65% 61.65%
========================================
Files 55 55
Lines 4572 4572
========================================
Hits 2819 2819
Misses 1753 1753 |
felixdivo
approved these changes
Sep 20, 2018
Collaborator
There was a problem hiding this comment.
Looks good, apart from the example file. (see below)
| @@ -1,18 +1,18 @@ | |||
| date Sam Sep 30 15:06:13.191 2017 | |||
Collaborator
There was a problem hiding this comment.
@christiansandberg Do ASC files work with any line endings? It should work with our tools, but do they work with the proprietary tools?
Contributor
Author
There was a problem hiding this comment.
I made the change blind, hoping nothing would regress 😛 clearly I was wrong. This wasn't flagged by the RPM linter, so I can roll back this file.
Unix-style is by far the most common, so convert the 7 files that don't conform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unix-style is by far the most common, so convert the 6 files that don't conform.