Stop raising accuracy error for NeoVi#336
Merged
felixdivo merged 1 commit intohardbyte:developfrom Jun 25, 2018
pierreluctg:neovi-error
Merged
Stop raising accuracy error for NeoVi#336felixdivo merged 1 commit intohardbyte:developfrom pierreluctg:neovi-error
felixdivo merged 1 commit intohardbyte:developfrom
pierreluctg:neovi-error
Conversation
Will only keep logging the error that ICS lib consider critical and no longer raise them. In most case, the error is affecting the accuracy but the device can still be use normally (i.e. Rx buffer overflow). In these cases, we do not want for example to kill a notifier using this bus, etc.
Collaborator
Author
|
Python 3.4 Travis job failed because of a connection timeout when downloading Python 3.4 archive. Unfortunately I do not have permission to re-run this jobs. All the other Python jobs are passing.
|
Collaborator
|
Done. Now it works. :) |
hardbyte
approved these changes
Jun 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only keep logging the error that ICS lib consider critical and stop raising exception. In most case, the error is affecting the accuracy but the device can still be use normally (i.e. Rx buffer overflow). In these cases, we do not want for example to kill a notifier using this bus, etc.