8000 Fix 328 by AntonioCohimbra · Pull Request #330 · hardbyte/python-can · GitHub
[go: up one dir, main page]
Skip to content

Fix 328#330

Merged
felixdivo merged 2 commits intohardbyte:developfrom
AntonioCohimbra:fix-328
Jun 18, 2018
Merged

Fix 328#330
felixdivo merged 2 commits intohardbyte:developfrom
AntonioCohimbra:fix-328

Conversation

@AntonioCohimbra
Copy link
Contributor
@AntonioCohimbra AntonioCohimbra commented Jun 18, 2018 •
edited by felixdivo
Loading

Closes 328.

@felixdivo
Copy link
Collaborator
felixdivo commented Jun 18, 2018 8000

This doesn't really allow more than the two filters, right?

@christiansandberg
Copy link
Collaborator
christiansandberg commented Jun 18, 2018

As I interpreted the API docs, you can only set one filter per ID type, but I don't remember actually testing it.

@felixdivo
Copy link
Collaborator
felixdivo commented Jun 18, 2018 •
edited
Loading

Yes, that's how I got that as well. I was just confused by the commit message "allow more than one filter for vector". Ah, but now I get how the bugfix works!

@felixdivo felixdivo merged commit b865a93 into hardbyte:develop Jun 18, 2018
@felixdivo felixdivo mentioned this pull request Jun 18, 2018
Closed
@AntonioCohimbra
Copy link
Contributor Author
AntonioCohimbra commented Jun 19, 2018

From the vector doc I also understood, that only 1 filter per ID type is possible. Reading it again, it also could work with more than that... Anyway it is possible to pack multiple message IDs in one call of SetChannelAcceptance by combining them in the mask parameter:

Binary General rule
ID = 6 (0x006) 0110 -
ID = 4 (0x004) 0100 -
Mask 1101 Compare the Ids at each bit position. If they are different, mask at this bit position must be ‘0’.
Code 0110 Take one Id (it does not matter which one).

@AntonioCohimbra AntonioCohimbra deleted the fix-328 branch June 19, 2018 06:41
@felixdivo
Copy link
Collaborator
felixdivo commented Jun 19, 2018 •
edited
Loading

Ah right: We could write an interface independent helper function that combines the masks, each for the extended and normal type. Then, we could send that to the driver, and signal in _receive_internal() that filtering has not yet taken place. That way, we at least let the driver do some of the "heavy lifting".

Do you by chance have time for that that as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christiansandberg christiansandberg christiansandberg approved these changes

Assignees

No one assigned

Labels

backend:vector bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AntonioCohimbra @felixdivo @christiansandberg
0