8000 Adding detect_available_configs support to neovi by pierreluctg · Pull Request #327 · hardbyte/python-can · GitHub
[go: up one dir, main page]

Skip to content

Adding detect_available_configs support to neovi#327

Merged
felixdivo merged 1 commit intohardbyte:developfrom
pierreluctg:neovi_detect_available_configs
Jun 14, 2018
Merged

Adding detect_available_configs support to neovi#327
felixdivo merged 1 commit intohardbyte:developfrom
pierreluctg:neovi_detect_available_configs

Conversation

@pierreluctg
Copy link
Collaborator

No description provided.

Copy link
Collaborator
@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. After you added the channel(s), please also update #303.

@felixdivo
Copy link
Collaborator
felixdivo commented Jun 14, 2018

The CI tests fail because of this:

neovi_bus.py 26 WARNING You won't be able to use the ICS NeoVi can backend without the python-ics module installed!: No module named 'ics'

Not all libraries are installed by this. Maybe we should simply install all optional packages in tests.

@pierreluctg
Copy link
Collaborator Author
pierreluctg commented Jun 14, 2018

@felixdivo adding python-ics to tests_require is not a problem. However, using it requires have the neovi driver installed (or in the path) this will be problematic.

For now we can simply return a empty list from detect_available_configs if python-ics is unavailable. What do you think?

@felixdivo
Copy link
Collaborator

Hm I see. Sounds good.

@felixdivo felixdivo merged commit 022cb48 into hardbyte:develop Jun 14, 2018
@pierreluctg pierreluctg deleted the neovi_detect_available_configs branch June 25, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0