Conversation
…neric CI skipping behaviour
Collaborator
Author
|
Done. |
Owner
|
This is great - thanks! Just a note about merging your own PRs, I'd prefer that we have someone else review almost all changes into develop - even if this slows changes down a bit. This PR is an example of a small enough change where it is okay to skip that (which is why I didn't make it mandatory in the settings) but I thought I'd just mention it anyways. :-) |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds CI tests on Windows. I also factored out common skipping behavior (
@skipIf(IS_TRAVIS, "...")) and replaced it with generic CI skipping behavior (@skipIf(IS_CI, "...")). The constants are defined intest/config.pyand define some properties in a central place:Closes #260.
Still work in progress.