add a deprecated notice to 'SqlReader' for users#263
add a deprecated notice to 'SqlReader' for users#263
Conversation
|
Oh wow, the Deprecated library is strange. Anyways, it seems like we forgot to include |
| # TODO remove in later releases? | ||
| SqlReader = SqliteReader | ||
| # SqliteReader is the newer name | ||
| SqliteReader = SqlReader |
There was a problem hiding this comment.
Won't the SqliteReader also be marked as deprecated with this approach?
There was a problem hiding this comment.
Yes yes, it all doesn't work like I intended. But de we really need this deprecation at all? We already broke compatibility.
There was a problem hiding this comment.
Hmm I didn't realize we'd already broken compatibility - in that case no we don't really need this deprecation warning. Lets just close this PR and remove the SqlReader/SqliteReader alias.
|
Yeah, I will do that. |
I changed the structure of
setup.pya little bit and added the Deprecated library as a dependency, as suggested by Brian. Then I added the@deprecateddecorator to mark SqlReader as - you guessed it - deprecated.