Conversation
Collaborator
Author
|
"Squash and merge" would probably be best for this since I needed many small commits to test the Travis CI script. |
Collaborator
|
The default cyclic transmission is a bit problematic since it depends on available CPU resources to work reliably. Travis' OS X machines are probably choked. |
Collaborator
Author
|
That's true, but it's not about this issue. BTW: The problem exists on Linux as well, as linked in #243. |
boris-wenzlaff
pushed a commit
to boris-wenzlaff/python-can
that referenced
this pull request
Mar 23, 2018
* added osx to travis test targets * Improve test failure messages * Make timing tests more forgiving for travis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some more test platforms, most notably OSX tests for Python 3.6-dev, 3.7-dev and nighly. I also changed the Travis CI file to allow nightly Python builds to fail, but they are still tested and the results can be viewed.
Now, there are generally more comments in
.travis.yml. For someone reviewing this, I would kindly ask them to read the comments in there and decide whether the chosen approach for OSX support & disallowing/allwoing dev/nightly builds was OK.For the failing tests, see #243. I think they are not directly connected to the changes in this PR.