Allow additional entries in config files#172
Closed
christiansandberg wants to merge 0 commit intohardbyte:developfrom
Closed
Allow additional entries in config files#172christiansandberg wants to merge 0 commit intohardbyte:developfrom
christiansandberg wants to merge 0 commit intohardbyte:developfrom
Conversation
a4956ec to
cbcd4d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds ability to specify more than interface and channel in config files. Specifying bitrate is supported also through CAN_BITRATE environment variable.
One limitation is that everything except bitrate will be passed as strings. I don't know if we should try to convert everything to integers instead.