8000 Fix inefficiencies, causes write delays to drop by silverv · Pull Request #1572 · hardbyte/python-can · GitHub
[go: up one dir, main page]
Skip to content

Fix inefficiencies, causes write delays to drop #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix inefficiencies, causes write delays to drop #1572

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c61634
Fix inefficiencies, causes write delays to drop
Apr 21, 2023
890c4ed
Remove removed timeout
Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove removed timeout
  • Loading branch information
Silver Valdvee committed Apr 21, 2023
commit 890c4edb0d61d881d42c3c541a5a8cc1eea7a731
2 changes: 0 additions & 2 deletions can/interfaces/slcan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ def _write(self, string: str) -> None:
self.serialPortOrig.flush()

def _read(self, timeout: Optional[float]) -> Optional[str]:
_timeout = serial.Timeout(timeout)

with error_check("Could not read from serial device"):
in_waiting = self.serialPortOrig.in_waiting
if in_waiting:
Expand Down
0