8000 Specific Exceptions: Adapting usb2can interface (+ simplify + partially type) by felixdivo · Pull Request #1091 · hardbyte/python-can · GitHub
[go: up one dir, main page]
Skip to content

Specific Exceptions: Adapting usb2can interface (+ simplify + partially type) #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2021
Merged

Specific Exceptions: Adapting usb2can interface (+ simplify + partially type) #1091

merged 2 commits into from
Jul 14, 2021

Conversation

felixdivo
Copy link
Collaborator

Part of #1046.

@felixdivo felixdivo added this to the 4.0.0 Release milestone Jun 13, 2021
@felixdivo felixdivo self-assigned this Jun 13, 2021
@mergify mergify bot requested a review from hardbyte June 13, 2021 08:57
@felixdivo felixdivo mentioned this pull request Jun 13, 2021
Closed
21 tasks
@codecov
Copy link
codecov bot commented Jun 13, 2021 •
edited
Loading

Codecov Report

Merging #1091 (24bd95b) into develop (8e6f05a) will increase coverage by 0.32%.
The diff coverage is 35.48%.

@@             Coverage Diff             @@
##           develop    #1091      +/-   ##
===========================================
+ Coverage    70.66%   70.99%   +0.32%     
===========================================
  Files           79       79              
  Lines         7616     7588      -28     
===========================================
+ Hits          5382     5387       +5     
+ Misses        2234     2201      -33

hardbyte
hardbyte approved these changes Jul 14, 2021
View reviewed changes
can/interfaces/usb2can/usb2canabstractionlayer.py
Comment on lines +105 to +110
@contextmanager
def error_check(error_message: str) -> None:
try:
yield
except Exception as error:
raise can.CanOperationError(error_message) from error
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's neat

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's Brian for the chunk of reviews!

@hardbyte hardbyte merged commit ead8c70 into develop Jul 14, 2021
@hardbyte hardbyte deleted the felixdivo-issue-1046-usb2can-new branch July 14, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers 5D49

@hardbyte hardbyte hardbyte approved these changes

Assignees

@felixdivo felixdivo

Labels
backend:usb2can enhancement
Projects
None yet
Milestone
4.0.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdivo @hardbyte
0