8000 Supress exception occuring in NIXNET _detect_available_configs() by felixdivo · Pull Request #1085 · hardbyte/python-can · GitHub
[go: up one dir, main page]
Skip to content

Supress exception occuring in NIXNET _detect_available_configs() #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 24, 2021
Merged

Supress exception occuring in NIXNET _detect_available_configs() #1085

merged 10 commits into from
Jun 24, 2021

Conversation

felixdivo
Copy link
Collaborator

Similar to #1077: If the python nixnet package is installed but not the DLL, the following error would be thrown:

nixnet._lib.XnetNotFoundError:
Could not find an installation of NI-XNET.
Please ensure that NI-XNET is installed on this machine or contact National Instruments for support.

Also uses a context manager for more safety.

@felixdivo felixdivo added the bug label Jun 9, 2021
@felixdivo felixdivo added this to the 4.0.0 Release milestone Jun 9, 2021
@felixdivo felixdivo self-assigned this Jun 9, 2021
@mergify mergify bot requested a review from hardbyte June 9, 2021 09:16
@codecov
Copy link
codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #1085 (74b4176) into develop (0262b8d) will decrease coverage by 0.07%.
The diff coverage is 11.11%.

@@             Coverage Diff             @@
##           develop    #1085      +/-   ##
===========================================
- Coverage    70.64%   70.56%   -0.08%     
===========================================
  Files           79       79              
  Lines         7655     7658       +3     
===========================================
- Hits          5408     5404       -4     
- Misses        2247     2254       +7

@felixdivo felixdivo merged commit c64f162 into develop Jun 24, 2021
@mergify mergify bot deleted the felixdivo-fix-nixnet-detect_available_configs branch June 24, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardbyte hardbyte hardbyte approved these changes

Assignees

@felixdivo felixdivo

Labels
bug
Projects
None yet
Milestone
4.0.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdivo @hardbyte
0