Removed vertical slider code #65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 95.12% 90.71% -4.41%
==========================================
Files 15 15
Lines 1293 1293
==========================================
- Hits 1230 1173 -57
- Misses 63 120 +57
Continue to review full report at Codecov.
|
|
The tests pass on python 3.6, 3.7 and 3.8. I propose to take this opportunity to drop support for 3.5 and 2.7, to both speed up the test cycle, and to recognise the imminent deprecation. |
| @@ -5,8 +5,6 @@ python: | |||
| - "3.8" | |||
| - "3.7" | |||
| - "3.6" | |||
| - "3.5" | |||
| - "2.7" | |||
There was a problem hiding this comment.
These python versions should also be taken out of the setup.py file and the README.rst should be updated accordingly.
There was a problem hiding this comment.
Well spotted.
There was a problem hiding this comment.
stumbled over a python35 environment which didn't work with anesthetic anymore...
There was a problem hiding this comment.
Can you remember what it was that didn't work?
There was a problem hiding this comment.
The newest matplotlib (v3.1.2) which incorporates the vertical slider has dependency python>=3.6.
Maybe worth incorporating in the requirements? i.e.
matplotlib>=3.1.2
There was a problem hiding this comment.
Added as part of #73
Description
The vertical option for slider widgets
is now in the stable version of matplotlib, so we no longer need to replicate
it.
This PR was prompted (via a cron job test) by an update to pydocstyle that
flagged that the now unnecessary code did not have compliant docstrings. I
propose to resolve the issue by removing the code
Checklist:
flake8 anesthetic tests)pydocstyle --convention=numpy anesthetic)python -m pytest)