Fix endianness issue in AIX #797
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the good catch! This file comes from an upstream project. Can you submit a PR for this file? https://github.com/FStarLang/karamel/blob/master/include/krml/lowstar_endianness.h I'll approve it immediately and then we can make it trickle down to hacl-star. Thanks so much! |
I just created a PR in the upstream project. FStarLang/karamel#340 |
|
Fixed upstream. |
6341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIX (always a big-endian) doesn't have
__BYTE_ORDER__defined in any of its header files. GCC for this reason defines__BYTE_ORDER__in its own header files for AIX. But with XLC compiler, it's not the case.The issue is exposed while compiling the latest python --> python/cpython#102206