[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image change style #1444

Merged
merged 13 commits into from
Mar 14, 2024
Merged

Image change style #1444

merged 13 commits into from
Mar 14, 2024

Conversation

pseudotensor
Copy link
Collaborator

No description provided.

@mati-gp
Copy link
mati-gp commented Mar 12, 2024

I might be wrong but I think there's a bug in this line

h2ogpt/src/vision/utils_vision.py

Line 243 in d5c2b49

if enable_image and len(set(image_models).difference(valid_imagegen_models)) == 0:

If set(image_models).difference(valid_imagegen_models)) == 0 then it means that all models in image_models belong to valid_imagegen_models, which is OK and therefore it should not raise an exception.

It should be corrected to
if enable_image and len(set(image_models).difference(valid_imagegen_models)) != 0:

@pseudotensor pseudotensor marked this pull request as ready for review March 14, 2024 23:30
@pseudotensor pseudotensor merged commit 4d041ac into main Mar 14, 2024
2 checks passed
@pseudotensor pseudotensor deleted the image_change_style branch March 14, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pseudotensor @mati-gp