Add MySQL 8.0.19+ VALUES alias support for ON DUPLICATE KEY UPDATE #4268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Y UPDATE - Implement ValuesAliasExpression for handling alias.column references - Add ValuesAliasResolver for column resolution and value retrieval - Extend Parser to support INSERT ... VALUES ... AS alias syntax - Modify CommandWithValues and Insert classes to handle VALUES aliases - Maintain full backward compatibility with existing VALUES() function - Add comprehensive test coverage for new functionality - Follow H2 coding conventions and design patterns - Use proper imports instead of fully qualified class names This enhancement improves MySQL compatibility by supporting the modern VALUES alias syntax introduced in MySQL 8.0.19, allowing developers to use more readable and maintainable SQL code while preserving all existing functionality.
|
Thank you for your contribution! Please, try to create a Changes in We also prefer pure SQL test cases, you can put them into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements support for MySQL 8.0.19+ VALUES alias syntax in
INSERT ... ON DUPLICATE KEY UPDATEstatements.#4267
Implementation Details
New Classes:
ValuesAliasExpression- Expression for handlingalias.columnreferencesValuesAliasResolver- ColumnResolver for resolving alias column referencesModified Classes:
Parser.java- Added parsing forAS alias_nameafter VALUES clauseCommandWithValues.java- AddedvaluesAliasandvaluesAliasResolverfieldsInsert.java- Extended to create and manage VALUES alias resolverKey Features:
database.getMode().onDuplicateKeyUpdate)counter = counter + alias.counterVALUES()functionTesting
Added comprehensive test class
TestValuesAlias.javacovering:sql
-- Basic alias usage
INSERT INTO table (id, name) VALUES (1, 'John') AS new_user
ON DUPLICATE KEY UPDATE name = new_user.name;
-- Complex expressions
INSERT INTO stats (id, counter, total) VALUES (1, 3, 50.0) AS new_data
ON DUPLICATE KEY UPDATE counter = counter + new_data.counter, total = total + new_data.total;
-- Mixed syntax (new + old)
INSERT INTO table (id, name, value, extra) VALUES (1, 'test', 200, 'new') AS x
ON DUPLICATE KEY UPDATE name = x.name, value = VALUES(value), extra = x.extra;
-- Backward compatibility (old syntax still works)
INSERT INTO table (id, name) VALUES (1, 'test')
ON DUPLICATE KEY UPDATE name = VALUES(name);