Support PHP 8.1 #140
Merged
Support PHP 8.1 #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Sep 5, 2021
| - name: Run tests | ||
| run: ./vendor/bin/simple-phpunit | ||
| env: | ||
| SYMFONY_PHPUNIT_VERSION: 9.5 |
There was a problem hiding this comment.
Can we let the phpunit bridge decide the version?
There was a problem hiding this comment.
No, because it chooses 9.4 which causes the tests to fail on PHP 8.1.
There was a problem hiding this comment.
This change just forces it to use the latest PHPUnit 9.x on PHP 8, which is reasonable IMO.
There was a problem hiding this comment.
FYI, this will be fixed in the next Symfony releases: symfony/symfony#43200
|
|
||
| - name: Run tests | ||
| run: ./vendor/bin/simple-phpunit | ||
|
|
||
| build8: | ||
| name: Build PHP 8 |
There was a problem hiding this comment.
Why can't we use the "build" job?
There was a problem hiding this comment.
Easier to separate it out to force PHPUnit 9.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.