Highlight for loops, WITH NAME, token overhaul #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datakurre
added a commit
to robots-from-jupyter/robotkernel
that referenced
this pull request
Jan 29, 2019
|
Undertook a substantial effort to put some rigor behind the syntax highlighting: now have validated against the RFUG. Certainly better off now :) |
datakurre
added a commit
to robots-from-jupyter/robotkernel
that referenced
this pull request
Mar 5, 2019
|
More changes are coming: |
nrbgt
pushed a commit
to nrbgt/irobotframework
that referenced
this pull request
May 30, 2019
* gtri#2: azure pipelines, more formatting, etc * Set up CI with Azure Pipelines * gtri#2: try node 10 on windows * gtri#2: install kernels, return rc from run * gtri#2: some more fixes for windows, chrome * gtri#2: utf-8 all the things * gtri#2: try updating conda on windows * gtri#2: apparently have a local PR, so can just test before actual PR * gtri#2: force re-install of pyzmq on windows * gtri#2: only do zmq stuff in windows * gtri#2: try defaults first * gtri#2: try pip for zmq on windows * gtri#2: more chromedriver shenanigans, fix conda invocation * gtri#2: try more conda and completion stuff * gtri#2: more conda stuff * gtri#2: force jupyter_server * gtri#2: give up on linting on windows * gtri#2: normalize some browser stuff * gtri#2: linting * gtri#2: keep tightening up scripts, etc * gtri#2: fix more scripts * gtri#2: in, not == * gtri#2: back to defaults for windows * gtri#2: bring back the zmq hack * gtri#2: add win envs * move bootstrap * gtri#2: more windows * gtri#2: win test env extends test * gtri#2: skip more win * typo * longer timeout * gtri#2: on empty test, test everything, but fail on any * add fast fail -x to full test * gtri#2: combine tests and combine * gtri#2: normalize more things for windows * oh, windows npm * more verbose output * gtri#2: clean up more build stuff * just use jlpm * more win stuff * try moving packages * no src in packages * peering * errant output * linting * get more specific with tsc call * more work on shutdown * further simplify js stuff for win * more error weirdness on windows * try more tsconfig tricks * move tsconfig back up * lint first * more un-nesting * lint first * invoking scripts * wheeling * build once * install once * naming * move chromedriver import * don't run unit tests in build * combine needs nbformat * publish naming * naming, some conditions * try cobertura * lint actual src * gah, build, not b * enter the matrix * update test outputs for py version * doesn't like test * maybe in variables? * variables get uppercased? * drop py altogether on names * fix variable typo * maybe just os name * try conditions * re-combine some steps * always with the variables * more parameters * more parameters * condition can't see params? * always can be in if * bigger ifs * display name last? * try different variables * back to conditions * move import of nbformat to appropriate linter * remove python3 refs * split up build * fix artifact names * try using wheels/sdist * pytest whole module * accept jinja2 as a dependency, for now... use vdom if possible, later, or offer plain text (ick) * gah, missed jinja on non-win * wow, bad at this * add environment for testing in windows with python 3.7 * bump the npm tools * try old lts * add command for now * more verbose * move stuff back * execution_count normalizing * try win37 a couple times
nrbgt
added a commit
to nrbgt/irobotframework
that referenced
this pull request
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had been a while since I had done a thorough reading of the guide and test suite to catch more corner cases for highlighting. The most egregious oversight was for loops, which I even use in the test suite!
This adds:
FOR/ENDand:FORloops (old and new style)IN RANGEand friendsWITH NAMEvariable-2for variablesatomfor language constructs (FOR, etc)metafor settingsI'd like to add some way to test these things, e.g. the google-modes tests, but really would like hypothesis in the loop... so this might have to wait for another ticket, and just do more manual testing (THE IRONY).