E538 Implement Functionality for S3BucketServerSideEncryption by james00012 · Pull Request #1494 · gruntwork-io/terratest · GitHub
[go: up one dir, main page]
Skip to content

Implement Functionality for S3BucketServerSideEncryption #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2024
Merged

Implement Functionality for S3BucketServerSideEncryption #1494

merged 2 commits into from
Dec 24, 2024

Conversation

james00012
Copy link
Contributor

Description

Fixes #1080

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Make a plan for release of the functionality in this PR. If it delivers value to an end user, you are responsible for ensuring it is released promptly, and correctly. If you are not a maintainer, you are responsible for finding a maintainer to do this for you.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james00012 james00012 requested a review from denis256 as a code owner December 20, 2024 03:53
@james00012 james00012 merged commit d032448 into main Dec 24, 2024
2 of 3 checks passed
@james00012 james00012 deleted the assert-sse branch December 24, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check for ApplyServerSideEncryptionByDefault
2 participants
@james00012 @denis256
0