10000 shadow DOM drag re-append fix by adumesny · Pull Request #2963 · gridstack/gridstack.js · GitHub
[go: up one dir, main page]
Skip to content

shadow DOM drag re-append fix #2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

shadow DOM drag re-append fix #2963

merged 1 commit into from
Feb 25, 2025
+73 −1

Conversation

adumesny
Copy link
Member

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
shadow DOM drag re-append fix
51c383d 
* fix gridstack#2951
* check for helper not having a parent before re-appending (rather than search though entire dom + shadow)
* added example test
@adumesny adumesny merged commit 6b1a5c3 into gridstack:master Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

avoid shadow DOM element getting re-appended when dragging
1 participant
@adumesny
0