added gs-size-to-content support
#2892
Conversation
* fix gridstack#2886 * untested but should be fine :)
| @@ -1741,6 +1743,7 @@ export class GridStack { | |||
| n.noResize = Utils.toBool(el.getAttribute('gs-no-resize')); | |||
| n.noMove = Utils.toBool(el.getAttribute('gs-no-move')); | |||
| n.locked = Utils.toBool(el.getAttribute('gs-locked')); | |||
| n.sizeToContent = Utils.toBool(el.getAttribute('gs-size-to-content')); | |||
There was a problem hiding this comment.
I believe this one should support the number version as well. Without that, utilizing #2620 is not possible with gs-size-to-content.
There was a problem hiding this comment.
you are correct. file a bug, but as mentioned gs- attr is rather obsolete is real apps
There was a problem hiding this comment.
Will do, thanks.
Regarding it being "obsolete in real apps":
The Vue examples use render(), not to be confused by render functions, import { render } from 'vue' itself is a low-level API and not explained in Vue docs. It is simply not sufficient in frameworks / complex apps, as you can't simply use things like provide/inject, plugins, e.g. vue-router, Quasar, etc. inside the widget content. You would need to use createApp and do some low-level copying from the original app to that sub-app, then use that app to render widget content stuff, which is not really straightforward. So, I think gs- still has good use as it's far simpler and less prone in cases like this.
There was a problem hiding this comment.
real app should use JSON to load/save grids dynamically, and we have much better API support for all options... framework app (like my angular wrapper) gets callwed back to create the right component types.
Description
Checklist
yarn test)