10000 Add JRE dependency to Java components by lizard-boy · Pull Request #11 · grepdemos/localstack · GitHub
[go: up one dir, main page]
Skip to content

Add JRE dependency to Java components #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add JRE dependency to Java components #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c30392
Remove default Java installation
viren-nadkarni Sep 4, 2024
56e4e4c
Add Java dependency to OpenSearch and ElasticSearch
viren-nadkarni Sep 4, 2024
bea8f1d
Add Java dependency to DynamoDB
viren-nadkarni Sep 4, 2024 8000
ea21461
Add Java dependency to StepFunctions legacy
viren-nadkarni Sep 4, 2024
7026b8e
Add Java dependency to KCL utilities
viren-nadkarni Sep 4, 2024
853a189
Add Java dependency to Event Ruler
viren-nadkarni Sep 9, 2024
779ed6f
Make package imports top-level
viren-nadkarni Sep 10, 2024
0df1d82
Pass target to dependent package install step
viren-nadkarni Sep 10, 2024
a60dc53
Fix bad arg type
viren-nadkarni Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make package imports top-level
  • Loading branch information
@viren-nadkarni
viren-nadkarni committed Sep 12, 2024
commit 779ed6fde67ecf59d6fcaaf7dab17d007bf59d67
3 changes: 1 addition & 2 deletions localstack-core/localstack/services/dynamodb/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from localstack import config
from localstack.constants import ARTIFACTS_REPO, MAVEN_REPO_URL
from localstack.packages import InstallTarget, Package, PackageInstaller
from localstack.packages.java import java_package
from localstack.utils.archives import (
download_and_extract_with_retry,
update_jar_manifest,
Expand Down Expand Up @@ -44,8 +45,6 @@ def __init__(self):
self.java_version = "11"

def _prepare_installation(self, target: InstallTarget) -> None:
from localstack.packages.java import java_package

java_package.get_installer(self.java_version).install()

def _install(self, target: InstallTarget):
Expand Down
3 changes: 1 addition & 2 deletions localstack-core/localstack/services/events/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from localstack.packages import InstallTarget, Package, PackageInstaller
from localstack.packages.core import MavenPackageInstaller
from localstack.packages.java import java_package

# https://central.sonatype.com/artifact/software.amazon.event.ruler/event-ruler
EVENT_RULER_VERSION = "1.7.3"
Expand Down Expand Up @@ -30,8 +31,6 @@ def __init__(self):
self.java_version = "11"

def _prepare_installation(self, target: InstallTarget) -> None:
from localstack.packages.java import java_package

java_package.get_installer(self.java_version).install()


Expand Down
5 changes: 1 addition & 4 deletions localstack-core/localstack/services/opensearch/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
OPENSEARCH_PLUGIN_LIST,
)
from localstack.packages import InstallTarget, Package, PackageInstaller
from localstack.packages.java import java_package
from localstack.services.opensearch import versions
from localstack.utils.archives import download_and_extract_with_retry
from localstack.utils.files import chmod_r, load_file, mkdir, rm_rf, save_file
Expand Down Expand Up @@ -55,8 +56,6 @@ def __init__(self, version: str):
self.java_version = "11"

def _prepare_installation(self, target: InstallTarget) -> None:
from localstack.packages.java import java_package

# OpenSearch ships with a bundled JRE, but we still use LocalStack's JRE for predictability
java_package.get_installer(self.java_version).install()

Expand Down Expand Up @@ -233,8 +232,6 @@ def __init__(self, version: str):
self.java_version = "8"

def _prepare_installation(self, target: InstallTarget) -> None:
from localstack.packages.java import java_package

# ElasticSearch ships with a bundled JRE, but we still use LocalStack's JRE for predictability
java_package.get_installer(self.java_version).install()

Expand Down
0