8000 feat: add UI badges for labeling beta features by lizard-boy · Pull Request #11 · grepdemos/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: add UI badges for labeling beta features #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: add UI badges for labeling beta features #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f843f23
chore: finish draft work for FeatureBadge component
Parkreiner Sep 12, 2024
43874a4
fix: add visually-hidden helper text for screen readers
Parkreiner Sep 12, 2024
fb70781
chore: add stories for highlighted state
Parkreiner Sep 12, 2024
c2470f9
fix: update base styles
Parkre 8000 iner Sep 12, 2024
693946f
chore: remove debug display option
Parkreiner Sep 12, 2024
c2d7cda
Merge branch 'main' into mes/beta-badges
Parkreiner Sep 13, 2024
129613b
chore: update Popover to propagate events
Parkreiner Sep 13, 2024
6adea6b
wip: commit progress on FeatureBadge update
Parkreiner Sep 13, 2024
d4455a8
wip: commit more progress
Parkreiner Sep 13, 2024
8ae71d3
chore: update tag definitions to satify Biome
Parkreiner Sep 13, 2024
0ad68af
chore: update all colors for preview role
Parkreiner Sep 13, 2024
781a609
fix: make sure badge shows as hovered while inside tooltip
Parkreiner Sep 13, 2024
a981864
wip: commit progress on adding story for controlled variant
Parkreiner Sep 13, 2024
f47d059
fix: sort imports
Parkreiner Sep 16, 2024
ad61763
refactor: change component API to be more obvious/ergonomic
Parkreiner Sep 16, 2024
6e16aaa
fix: add biome-ignore comments to more base files
Parkreiner Sep 16, 2024
6a19b61
fix: update import order again
Parkreiner Sep 16, 2024
a233867
chore: revert biome-ignore comment
Parkreiner Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update base styles
  • Loading branch information
@Parkreiner
Parkreiner committed Sep 12, 2024
commit c2470f97f5868964494e4667c785f2a1d3f2ac14
3 changes: 3 additions & 0 deletions site/src/components/FeatureBadge/FeatureBadge.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import { FeatureBadge } from "./FeatureBadge";
const meta: Meta<typeof FeatureBadge> = {
title: "components/FeatureBadge",
component: FeatureBadge,
args: {
type: "beta",
},
};

export default meta;
Expand Down
11 changes: 7 additions & 4 deletions site/src/components/FeatureBadge/FeatureBadge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,19 @@ const styles = {
// more types of HTML elements without creating invalid markdown, but we
// still want the default display behavior to be div-like
display: "block",

// Base style assumes that small badges will be the default
fontSize: "0.75rem",

maxWidth: "fit-content",
flexShrink: 0,
padding: "8px 4px",
padding: "4px 8px",
lineHeight: 1,
whiteSpace: "nowrap",
border: `1px solid ${theme.palette.divider}`,
color: theme.palette.text.secondary,
backgroundColor: theme.palette.background.default,
borderRadius: "6px",

// Base style assumes that small badges will be the default
fontSize: "0.75rem",
}),

highlighted: (theme) => ({
Expand Down
0