8000 Pick up the docstrings of hybrid properties by bim9262 · Pull Request #298 · graphql-python/graphene-sqlalchemy · GitHub
[go: up one dir, main page]
Skip to content

Pick up the docstrings of hybrid properties #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Pick up the docstrings of hybrid properties #298

wants to merge 1 commit into from

Conversation

bim9262
Copy link
Contributor
@bim9262 bim9262 commented Feb 2, 2021

Use the docstring of hybrid properties as the description.

@coveralls
Copy link
coveralls commented Feb 2, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 97.619% when pulling 5a3c843 on bim9262:hybrid_property_description into 20ecaea on graphql-python:master.

@bim9262
Copy link
Contributor Author
bim9262 commented Feb 3, 2021

The tox.ini and setup.py's sqlalchemy version requirements are at odds:

ERROR:   py37-sql11: could not install deps [.[test], sqlalchemy>=1.1,<1.2]; v = InvocationError("/tmp/graphene-sqlalchemy/.tox/py37-sql11/bin/python -m pip install '.[test]' 'sqlalchemy>=1.1,<1.2'", 1)

@bim9262
Copy link
Contributor Author
bim9262 commented Feb 3, 2021

Bumped build requirments for sqlalchemy becase as noted in the
documentation before version 1.3.19 the ordering for
all_orm_descriptors was not deterministic:

.. versionchanged:: 1.3.19 ensured deterministic ordering for
   :meth:`_orm.Mapper.all_orm_descriptors`.

@bim9262
Pick up the docstrings of hybrid properties
5a3c843 
Use the docstring of hybrid properties as the description.

Bumped build requirments for sqlalchemy becase as noted in the
documentation before version 1.3.19 the ordering for
all_orm_descriptors was not deterministic:

```
.. versionchanged:: 1.3.19 ensured deterministic ordering for
   :meth:`_orm.Mapper.all_orm_descriptors`.
```

Updated .travis.yml to match tox.ini and setup.py
@erikwrede
Copy link
Member

Thanks for the PR! I think it is a handy feature to have since adding the documentation in the ObjectTypes is a lot of redundant work. However, I think dropping support of SQA < 1.3.19 is very critical. Is there a way to add this without dropping support for two major releases of SQLAlchemy?

erikwrede
erikwrede reviewed Apr 29, 2022
View reviewed changes
Copy link
Member
@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dropping support of SQA < 1.3.19 is critical and should be avoided. Is there a way to add this without dropping support for two major releases of SQLAlchemy?

@bim9262
Copy link
Contributor Author
bim9262 commented May 4, 2022

@erikwrede , I'll take a look. It's been a while since I've looked at this... Looks like some rebasing is in order too.

@bim9262 bim9262 mentioned this pull request May 4, 2022
Merged
@bim9262 bim9262 closed this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwrede erikwrede erikwrede left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bim9262 @coveralls @erikwrede
0