Add typed filters (v2) #1142
Merged
Add typed filters (v2) #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to cherry pick the PR #1136 (which should be ready to be merged) as it partially depends on it. |
|
@tcleonard #1136 is merged 🎉 |
|
@tcleonard Is there any chance for instead of merging v2 into the this branch, just rebase this branch onto v2? |
15f3466 to
91fed29
Compare
|
I have rebased and squashed commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to declare filters with an explicit GraphQL argument type.
(note that a big portion of this PR is simply to split up the filters into separate files to be more maintainable)