lint

graphql-python · ekampf · Jan 2, 2019 · Jan 2, 2019 · Jan 2, 2019 · Jan 2, 2019
commit 1746bdb737c9ccbbcb2b7fd3a382e59af3b657a6
diff --git a/gql/clients/sync.py b/gql/clients/sync.py
@@ -16,9 +16,9 @@ def __init__(self, endpoint, headers=None):
         }
 
     def call(self, query,
-                   variables=None,
-                   return_json=False,
-                   on_before_callback: Callable[[Mapping[str, str], Mapping[str, str]], None] = None) -> Union[dict, str]:
+             variables=None,
+             return_json=False,
+             on_before_callback: Callable[[Mapping[str, str], Mapping[str, str]], None] = None) -> Union[dict, str]:
 
         headers = self.__headers.copy()
 

diff --git a/gql/codec/register.py b/gql/codec/register.py
@@ -1,28 +1,31 @@
 #!/usr/bin/env python
+import sys
 import codecs
 import encodings
-import sys
 from encodings import utf_8
 from io import BytesIO
 
-from gql.codec.transform import gql_transform, gql_transform_string
+from gql.codec.transform import gql_transform
 
 
-def gql_decode(input, errors='strict'):
-    return utf_8.decode(input)
-    # return utf_8.decode(gql_transform_string(input), errors)
+def gql_decode(value, **_):
+    return utf_8.decode(value)
 
 
 class GQLIncrementalDecoder(utf_8.IncrementalDecoder):
-    def decode(self, input: bytes, final: bool=False):
+    def decode(self, input: bytes, final: bool = False):  # pylint:disable=redefined-builtin
         self.buffer += input
         if final:
             buff = self.buffer
             self.buffer = ''
             return gql_transform(BytesIO(buff))
 
+        return None
+
 
 class GQLStreamReader(utf_8.StreamReader):
+    # pylint:disable=abstract-method
+
     def __init__(self, *args, **kwargs):
         super().__init__(self, *args, **kwargs)
         self.stream = BytesIO(gql_decode(self.stream))
@@ -41,7 +44,8 @@ def search_function(encoding):
         incrementalencoder=utf8.incrementalencoder,
         incrementaldecoder=GQLIncrementalDecoder,
         streamreader=GQLStreamReader,
-        streamwriter=utf8.streamwriter)
+        streamwriter=utf8.streamwriter
+    )
 
 
 codecs.register(search_function)
@@ -55,7 +59,9 @@ def search_function(encoding):
     python -m gql.codec.register path/to/script.py [args...]
 """
 
-if __name__ == '__main__':
+
+def main():
+    # pylint:disable=exec-used,redefined-builtin,global-statement
     script = None
     if len(sys.argv) >= 3 and sys.argv[1] == '-m':
         mode = 'module'
@@ -73,12 +79,16 @@ def search_function(encoding):
         import runpy
         runpy.run_module(module, run_name='__main__', alter_sys=True)
     elif mode == 'script':
-        with open(script, encoding='gql') as f:
+        with open(script) as file:
             global __file__
             __file__ = script
             # Use globals as our "locals" dictionary so that something
             # that tries to import __main__ (e.g. the unittest module)
             # will see the right things.
-            code = f.read()
+            code = file.read()
             print(code)
             exec(code, globals())
+
+
+if __name__ == '__main__':
+    main()
diff --git a/gql/codec/transform.py b/gql/codec/transform.py
@@ -87,8 +87,8 @@ def gql_transform(stream: BytesIO):
     return result.rstrip()
 
 
-def gql_transform_string(input: str):
-    stream = BytesIO(input.encode('utf-8'))
+def gql_transform_string(value: str):
+    stream = BytesIO(value.encode('utf-8'))
     return gql_transform(stream)
 
 

diff --git a/gql/renderer_dataclasses.py b/gql/renderer_dataclasses.py
@@ -53,7 +53,8 @@ def render(self, parsed_query: ParsedQuery):
 
         return str(buffer)
 
-    def get_operation_class_name(self, parsed_query: ParsedQuery):
+    @staticmethod
+    def get_operation_class_name(parsed_query: ParsedQuery):
         for obj in parsed_query.objects[::-1]:
             if isinstance(obj, ParsedOperation):
                 return obj.name