Add thread.join to tests

graphql-python · leszekhanusz · Sep 13, 2023 · Sep 9, 2023 · Sep 9, 2023 · Sep 9, 2023
commit 02f249e23d4d12b1a080280d16d0b1e0165b93af
diff --git a/tests/test_requests_batch.py b/tests/test_requests_batch.py
@@ -162,6 +162,8 @@ async def handler(request):
     def test_code():
         transport = RequestsHTTPTransport(url=url)
 
+        threads = []
+
         with Client(
             transport=transport,
             batch_interval=0.01,
@@ -187,6 +189,10 @@ def test_thread():
             for _ in range(2):
                 thread = Thread(target=test_thread)
                 thread.start()
+                threads.append(thread)
+
+        for thread in threads:
+            thread.join()
 
     await run_sync_test(event_loop, server, test_code)
 
@@ -581,6 +587,7 @@ def get_continent_name(session, continent_code):
                 ),
             )
             thread.start()
+            thread.join()
 
     # Doing it twice to check that everything is closing and reconnecting correctly
     with client as session:
@@ -595,6 +602,7 @@ def get_continent_name(session, continent_code):
                 ),
             )
             thread.start()
+            thread.join()
 
 
 @pytest.mark.online