8000 Adding missed properties on IncrementalExecutionResultImpl.Builder.from by Juliano-Prado · Pull Request #3593 · graphql-java/graphql-java · GitHub
[go: up one dir, main page]
Skip to content

Adding missed properties on IncrementalExecutionResultImpl.Builder.from #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 3 commits into from
Jun 1, 2024
Merged

Adding missed properties on IncrementalExecutionResultImpl.Builder.from #3593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c5afc
Adding missed properties on IncrementalExecutionResultImpl.Builder.from
Juliano-Prado May 13, 2024
362a6e4
Adding test to method FROM
Juliano-Prado May 15, 2024
d40a353
Update src/test/groovy/graphql/incremental/IncrementalExecutionResult…
bbakerman Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8000
2 changes: 2 additions & 0 deletions src/main/java/graphql/incremental/IncrementalExecutionResultImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ public Builder incrementalItemPublisher(Publisher<DelayedIncrementalPartialResul
public Builder from(IncrementalExecutionResult incrementalExecutionResult) {
super.from(incrementalExecutionResult);
this.hasNext = incrementalExecutionResult.hasNext();
this.incremental = incrementalExecutionResult.getIncremental();
this.incrementalItemPublisher = incrementalExecutionResult.getIncrementalItemPublisher();
Copy link
Member
@dondonz dondonz May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you were already in the progress of doing it. Could you please add a test for this?

Copy link
Member
@bbakerman bbakerman May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test please

Copy link
Contributor Author
@Juliano-Prado Juliano-Prado May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the tests, check out: src/test/groovy/graphql/incremental/IncrementalExecutionResultTest.groovy

return this;
}

Expand Down
38 changes: 38 additions & 0 deletions src/test/groovy/graphql/incremental/IncrementalExecutionResultTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package graphql.incremental

import graphql.execution.ResultPath
import groovy.json.JsonOutput
import io.reactivex.Flowable
import org.reactivestreams.Publisher
import spock.lang.Specification

import static graphql.incremental.DeferPayload.newDeferredItem
Expand Down Expand Up @@ -80,6 +83,41 @@ class IncrementalExecutionResultTest extends Specification {
extensions: [some: "map"],
hasNext : false,
]
}

def "sanity test to check Builder.from works"() {

when:
def defer1 = newDeferredItem()
.label("homeWorldDefer")
.path(ResultPath.parse("/person"))
.data([homeWorld: "Tatooine"])
.build()


def incrementalExecutionResult = new IncrementalExecutionResultImpl.Builder()
.data([
person: [
name : "Luke Skywalker",
films: [
[title: "A New Hope"]
]
]
])
.incrementalItemPublisher { Flowable.range(1,10)}
.hasNext(true)
.incremental([defer1])
.extensions([some: "map"])
.build()

def newIncrementalExecutionResult = new IncrementalExecutionResultImpl.Builder().from(incrementalExecutionResult).build()

then:
newIncrementalExecutionResult.incremental == incrementalExecutionResult.incremental
newIncrementalExecutionResult.extensions == incrementalExecutionResult.extensions
newIncrementalExecutionResult.errors == incrementalExecutionResult.errors
newIncrementalExecutionResult.incrementalItemPublisher == incrementalExecutionResult.incrementalItemPublisher
newIncrementalExecutionResult.hasNext() == incrementalExecutionResult.hasNext()
newIncrementalExecutionResult.toSpecification() == incrementalExecutionResult.toSpecification()
}
}
0