8000 Fix flaky defer test by felipe-gdr · Pull Request #3455 · graphql-java/graphql-java · GitHub
[go: up one dir, main page]
Skip to content

Fix flaky defer test #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 1 commit into from
Feb 18, 2024
Merged

Fix flaky defer test #3455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions src/test/groovy/graphql/execution/incremental/DeferExecutionSupportIntegrationTest.groovy 10BC0
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package graphql.execution.incremental

import com.google.common.collect.Iterables
import graphql.Directives
import graphql.ExecutionInput
import graphql.ExecutionResult
import graphql.ExperimentalApi
import graphql.GraphQL
import graphql.GraphQLContext
import graphql.TestUtil
import graphql.execution.pubsub.CapturingSubscriber
import graphql.incremental.DelayedIncrementalPartialResult
Expand Down Expand Up @@ -254,9 +254,9 @@ class DeferExecutionSupportIntegrationTest extends Specification {
id2: id
}
}
... @defer {
... @defer(label: "defer-post3") {
post3: postById(id: "3") {
... @defer {
... @defer(label: "defer-id3") {
id3: id
}
}
Expand All @@ -277,35 +277,35 @@ class DeferExecutionSupportIntegrationTest extends Specification {
def incrementalResults = getIncrementalResults(initialResult)

then:
incrementalResults == [
[
hasNext : true,
incremental: [
[
path: [],
data: [post2: [id2: "2"]]
]
]
],
[
hasNext : true,
incremental: [
[
path: [],
data: [post3: [:]]
]
]
],
[
hasNext : false,
incremental: [
[
path: ["post3"],
data: [id3: "3"]
]
]
]
]
// Ordering is non-deterministic, so we assert on the things we know are going to be true.

incrementalResults.size() == 3
// only the last payload has "hasNext=true"
incrementalResults[0].hasNext == true
incrementalResults[1].hasNext == true
incrementalResults[2].hasNext == false

// every payload has only 1 incremental item
incrementalResults.every { it.incremental.size() == 1 }

incrementalResults.any {
it.incremental[0] == [path: [], data: [post2: [id2: "2"]]]
}

// id3 HAS TO be delivered after post3
def indexOfPost3 = Iterables.indexOf(incrementalResults, {
it.incremental[0] == [path: [], label: "defer-post3", data: [post3: [:]]]
})

def indexOfId3 = Iterables.indexOf(incrementalResults, {
it.incremental[0] == [path: ["post3"], label:"defer-id3", data: [id3: "3"]]
})

// Assert that both post3 and id3 are present
indexOfPost3 >= 0
indexOfId3 >= 0
// Assert that id3 is delivered after post3
indexOfId3 > indexOfPost3
}

def "defer on interface field"() {
Expand Down
0