This moves the AST element builder to use immutable lists #2101
Merged
This moves the AST element builder to use immutable lists #2101
Conversation
…ility to add items to individually
andimarek
approved these changes
Nov 15, 2020
Member
There was a problem hiding this comment.
see the one comment, but not really needed now. LGTM
| private ImmutableList<Directive> directives = emptyList(); | ||
| private ImmutableList<InputValueDefinition> inputValueDefinitions = emptyList(); | ||
| private IgnoredChars ignoredChars = IgnoredChars.EMPTY; | ||
| private Map<String, String> additionalData = new LinkedHashMap<>(); |
Member
There was a problem hiding this comment.
we could change this to ImmutableMap or ImmutableMapWithNullValue too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This make the AST elements use immutable lists inside themselves (for performance reasons since they are created on every request but we have convenience methods for the single item add methods from before.
Related to #2099