8000 align return types from execution and subscription by yaacovCR · Pull Request #3620 · graphql/graphql-js · GitHub
[go: up one dir, main page]
Skip to content

align return types from execution and subscription #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2022
Merged

align return types from execution and subscription #3620

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
713480f
align return types from execution and subscription
yaacovCR May 31, 2022
e9700ca
fix typo
yaacovCR Jun 8, 2022
ba4c80f
refactor suggestion
IvanGoncharov Jun 9, 2022
f88b523
apply review feedback
yaacovCR Jun 9, 2022
5139ec2
rename eventStream to result
yaacovCR Jun 9, 2022
6714bbe
add TODOs
yaacovCR Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add TODOs
  • Loading branch information
@yaacovCR
yaacovCR committed Jun 9, 2022
commit 6714bbe814b60636fd6e85527d4b21a544ba783b
2 changes: 2 additions & 0 deletions src/execution/__tests__/subscribe-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ function createSubscription(pubsub: SimplePubSub<Email>) {
return subscribe({ schema: emailSchema, document, rootValue: data });
}

// TODO: consider adding this method to testUtils (with tests)
function expectPromise(maybePromise: unknown) {
assert(isPromise(maybePromise));

Expand All @@ -149,6 +150,7 @@ function expectPromise(maybePromise: unknown) {
};
}

// TODO: consider adding this method to testUtils (with tests)
function expectEqualPromisesOrValues<T>(
value1: PromiseOrValue<T>,
value2: PromiseOrValue<T>,
Expand Down
0