bus access #2913
Merged
bus access #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Will this PR also result in a new transportation profile at GraphHopper Maps? Currently, I'm using custom profiles but they do not work for distances further than 500 km apart. |
no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a compound boolean EncodedValue
bus_accessincluding theonewayhandling but withoutroad_classhandling ("bus" in the sense of a psv = public service vehicle).A separate
bus_oneway_accessis unnecessary as the only known use case atm (for ambulances) would be to allow opposite travel of oneways which could be achieved withbackward_bus_accessinstead.This is a replacement of #2710. The new ModeAccessParser can be used with any of the values in the TransportationMode enum e.g. also
motorcycle. The idea is that is can be (later) used as a replacement for CarAccessParser too. (Furthermore the oneway code in CarAccessParser should be simplified)Unfortunately the enum in #2710 cannot handle oneway roads properly. For #2710 there is a problem: if bus=yes on oneway roads and motor_vehicle=no then the bus profile would allow access in the opposite direction of the oneway road too. See this route as an example. (We could make the enum direction-dependent to handle oneway roads. Then we could also consider tags like "bus=designated" in the profile to prefer these ways. But this would be too confusing as the enum would no longer represent the OSM data and bus==YES in the custom_model would not necessarily mean bus=yes in OSM.)
The usage is outlined in the bus.json.