-
Notifications
You must be signed in to change notification settings - Fork 256
fix: mixing directed and undirected edges in motif throws parse error #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
What about 2, 3 in the first example? |
|
0, 1, 2 repeats |
|
@rjurney It was with the condition |
|
The last commit removes the existing undirected pattern based on a regular expression, as the new one in the |
|
It looks ready for review, isn't it? |
Let me keep it draft this week. |
|
|
@rjurney The result is as expected, is there anything you're still unsure about? |
|
@goungoun Hello! Sorry for the delay with a review. I want to finish my work on graph embeddings first and I'm almost done... I will try to review your PR this week. Thanks for understanding! |
@SemyonSinchenko Thanks for your comment. I know you are running many things, please no rush as I can wait. |
What changes were proposed in this pull request?
This PR address the bug report #750
(u)-[e1]-(v);(v)-[e2]->(k)should not failWhy are the changes needed?
It improves the flexibility to use the motif pattern
Test Case