feat: add reverse edge pattern #716
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Awesome to see - I've wanted this feature for a long time! Let me know when it's ready for review. |
Contributor
Author
|
Hi @rjurney, now it is ready for review. For me, it looked more like a design choice rather than a feature. It is easy to come up with a workaround, would you elaborate on the use cases and the situation you've experienced? |
Contributor
Author
|
@rjurney, the PR changes the Parser, but it would be better to rewrite the query string to keep the parser unchanged. I will be opening another PR with that approach. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR addresses the reversed pattern
(u)<-[e]-(v). The parsed result is the same as the pattern(v)-[e]->(u).Why are the changes needed?
The parser should be able to understand the reverse edge pattern.