Fix trace batch size to match old behaviour #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelroquetto
approved these changes
Sep 23, 2025
rafaelroquetto
added a commit
to grafana/beyla
that referenced
this pull request
Sep 24, 2025
Include grafana/opentelemetry-ebpf-instrumentation#15 --------- Co-authored-by: Nikola Grcevski <grcevski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes we had to do to upgrade to the collector SDK exporter version 0.130 are not equivalent in behaviour to the old version 0.128 (which was experimental). Because of this change we are exporting data very frequently for traces and it might cause excessive calls to the OTel collector.
I'm introducing a change where we set the default timeout to 60 seconds for exporting traces and if that value is set, we then set the minimum size, forcing the batcher to batch the requests until 4K are filled up.
Relates to grafana/beyla#2199