8000 WIP - DO NOT REVIEW RFC: Integrate Beyla without eBPF binaries by rafaelroquetto · Pull Request #2734 · grafana/alloy · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - DO NOT REVIEW RFC: Integrate Beyla without eBPF binaries #2734

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP - DO NOT REVIEW RFC: Integrate Beyla without eBPF binaries #2734

wants to merge 1 commit into from

Conversation

rafaelroquetto
Copy link
Contributor

PR Description

Beyla will no longer include pre-built eBPF binaries and related artifacts. The main reasons are:

  • prevent malicious pre-compiled binaries from being injected into the Beyla tree
  • removing the binaries ensures that they remain consistent with the source code, preventing discrepancies.
  • repos importing Beyla (i.e. Alloy) won’t need to manage git-lfs, as the removal of pre-built binaries eliminates that requirement and reduces repository overhead
  • as a result, there's no longer need for special Beyla/Alloy release branches and any potential problems that arise with it

The eBPF binaries are now generated by an upstream docker image, that encapsulates all the necessary tooling.

As a result of how go mod vendor works by trimming non-used dependencies, and because go build can only be used to compile .go files, an extra Makefile target dependency and an extra "GOTAG" is required as fair trade-off trade-off.

I have opted to list both the dependency and the extra go-tag close to the place of usage, with the assumption that this will make it easier for their usage scope to be identified.

Non-Linux compilations should result as a no-op. This is abstracted on the Beyla side and there's no need for explicit checks on the Alloy end, except for the aforementioned extra Makefile target.

Notes to the Reviewer

Tested with make alloy and make alloy-image

Related Beyla PR

@rafaelroquetto rafaelroquetto changed the title RFC: Integrate Beyla without eBPF binaries WIP - DO NOT REVIEW RFC: Integrate Beyla without eBPF binaries Feb 15, 2025
@rafaelroquetto rafaelroquetto force-pushed the roquetto/beyla_gen branch 4 times, most recently from 3650b95 to e970369 Compare February 15, 2025 01:58
@rafaelroquetto rafaelroquetto mentioned this pull request Feb 15, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beyla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rafaelroquetto
0