8000 Cache Go modules and move some PR checks into one workflow. by ptodev · Pull Request #2722 · grafana/alloy · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Go modules and move some PR checks into one workflow. #2722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cache Go modules and move some PR checks into one workflow. #2722

wants to merge 1 commit into from
+272 −40

Conversation

ptodev
Copy link
Collaborator
@ptodev ptodev commented Feb 13, 2025

The setup-go action doesn't work well when there are multiple jobs using Go. This PR enables caching Go build files, but it does it using the caching action instead of setup-go. I used OpenTelemetry Collector's workflow for inspiration.

@ptodev ptodev requested a review from a team as a code owner February 13, 2025 19:30
mattdurham
mattdurham approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator
@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing obvious but only one way to tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdurham mattdurham mattdurham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptodev @mattdurham
0