Add the otelcol tcplog receiver #2701

nosammai · 2025-02-11T20:10:11Z

PR Description

This PR adds support for the otelcol tcp log receiver. I am not much of a golang programmer, so this PR was largely adapted from the one that added the syslog receiver.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

CHANGELOG.md updated
Documentation added
Tests updated
Config converters updated

CLAassistant · 2025-02-11T20:10:19Z

All committers have signed the CLA.

ptodev

Thank you! It looks good. I only added a few minor comments.

CHANGELOG.md

docs/sources/reference/components/otelcol/otelcol.receiver.tcplog.md

internal/component/otelcol/receiver/tcplog/tcplog.go

test_config.alloy

nosammai · 2025-02-12T16:03:46Z

Thanks for the review! Updated the PR based on your feedback.

For the max log size stuff - I pulled all of that out of the syslog receiver, so it might be worth going and making the same changes there as well at some point.

nosammai · 2025-02-12T16:26:13Z

Hmmm I can't get the test that's failing in CI to fail locally no matter how many times I run it.

I didn't copy this sleep over from the equivalent syslog test because that PR had been merged and it was passing locally. Do you think that would help?

https://github.com/nosammai/alloy/blob/otel-tcp-log-receiver/internal/component/otelcol/receiver/syslog/syslog_test.go#L61-L62

dehaansa · 2025-02-12T16:41:06Z

Hmmm I can't get the test that's failing in CI to fail locally no matter how many times I run it.

I didn't copy this sleep over from the equivalent syslog test because that PR had been merged and it was passing locally. Do you think that would help?

https://github.com/nosammai/alloy/blob/otel-tcp-log-receiver/internal/component/otelcol/receiver/syslog/syslog_test.go#L61-L62

We attempted to remove the test after that PR was merged and it still failed in CI, so it might be relevant here as well. Haven't had the opportunity to go back and wait for the port to be ready in a better way than just the 1s wait.

clayton-cornell

Most doc suggestions are style related to bring this new topic in-line with the new/upcoming markdown styles and information flow.

A few minor content corrections were included.

docs/sources/reference/components/otelcol/otelcol.receiver.tcplog.md

ptodev

Apologies for the delay with the review! I added just one minor comment. It'll also need a rebase with main and it would be ready for merging!

docs/sources/reference/components/otelcol/otelcol.receiver.tcplog.md

ptodev · 2025-02-19T11:05:44Z

I'm sorry, the main branch got an updated OTel version and now this receiver will need to be updated too... If you want to I can rebase your branch and update it? I feel bad for asking you to rebase so many times 😅

Co-authored-by: Paulin Todev <paulin.todev@gmail.com>

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

…log.md Co-authored-by: Paulin Todev <paulin.todev@gmail.com>

nosammai · 2025-02-19T15:42:28Z

No problem - rebased and updated to 0.119

dehaansa · 2025-02-19T17:47:02Z

We should consider adding operators to the receiver (like filelogreceiver #2711 ) to ensure the full capacity of the stanza pipeline that underlies the otel log receivers.

This was not done when syslogreceiver was added due to some issues I had with the implementation, but resolved when adding filelog. I'm intending to add it to syslog before next release, so I can add it to tcplog later as well if you don't have capacity to add it in with this PR.

nosammai · 2025-02-19T18:11:14Z

If you don't mind adding it in afterwards, I would appreciate that

nosammai · 2025-02-19T19:01:53Z

The build failure looks like a transient 502 from yarn. I don't think I have permission to retrigger the builds

nosammai requested review from clayton-cornell and a team as code owners February 11, 2025 20:10

ptodev self-assigned this Feb 12, 2025

ptodev mentioned this pull request Feb 12, 2025

Add OTel tcplogreceiver to Alloy #2471

Open

ptodev reviewed Feb 12, 2025

View reviewed changes

clayton-cornell reviewed Feb 13, 2025

View reviewed changes

clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 13, 2025

ptodev reviewed Feb 18, 2025

View reviewed changes

docs/sources/reference/components/otelcol/otelcol.receiver.tcplog.md Show resolved Hide resolved

nosammai force-pushed the otel-tcp-log-receiver branch from 242ef13 to bdbe244 8000 Compare February 18, 2025 20:04

nosammai and others added 7 commits February 19, 2025 10:35

Add the otelcol tcplog receiver

f2a50d1

Apply suggestions from code review

5da1dd8

Co-authored-by: Paulin Todev <paulin.todev@gmail.com>

Code review feedback for max log size

cd433cf

Add sleep into test

e7dbbe7

Apply suggestions from code review

0dc7c48

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

Update docs/sources/reference/components/otelcol/otelcol.receiver.tcp…

c9cda7d

…log.md Co-authored-by: Paulin Todev <paulin.todev@gmail.com>

fix for otel update

b340dd1

nosammai force-pushed the otel-tcp-log-receiver branch from bdbe244 to b340dd1 Compare February 19, 2025 15:41

dehaansa approved these changes Feb 19, 2025

View reviewed changes

clayton-cornell approved these changes Feb 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the otelcol tcplog receiver #2701

Add the otelcol tcplog receiver #2701

Add the otelcol tcplog receiver #2701

Are you sure you want to change the base?

Add the otelcol tcplog receiver #2701

Conversation

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment