8000 feature(prometheus.exporter.mongodb_): Add compatible_mode param for integration by lomobot · Pull Request #2611 · grafana/alloy · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(prometheus.exporter.mongodb_): Add compatible_mode param for integration #2611

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feature(prometheus.exporter.mongodb_): Add compatible_mode param for integration #2611

wants to merge 8 commits into from
+16 −11

Conversation

lomobot
Copy link
@lomobot lomobot commented Feb 4, 2025 •
edited
Loading

PR Description

New parameter compatible_mode were added for mongodb_exporter integration to have an opportunity to disable or enable this exporter's option.

Which issue(s) this PR fixes

Fixes #1510

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@lomobot
add CompatibleMode param for mongodb integration
d72b687 
Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>
@lomobot
change tests for mongodb_exporter integration
a316a41 
Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>
@lomobot
add info about compatible_mode for mongodb_exporter integration docs
5ca08e1 
Signed-off-by: Alexander Mukhin <67650646+lomobot@users.noreply.github.com>
@lomobot lomobot requested review from clayton-cornell and a team as code owners February 4, 2025 15:54
lomobot and others added 2 commits February 5, 2025 10:23
@lomobot @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.export…
c8284fe 
…er.mongodb.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@lomobot @clayton-cornell
Update docs/sources/reference/components/prometheus/prometheus.export…
a94b423 
…er.mongodb.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@clayton-cornell clayton-cornell requested a review from a team February 5, 2025 18:56
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 5, 2025
@clayton-cornell
Copy link
Contributor

Docs are OK. Over to @grafana/grafana-alloy-maintainers for code review :-)

ptodev
ptodev reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator
@ptodev ptodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my usecase i need to enable --compatible-mode flag for mongodb_exporter to get old metrics naming.

@lomobot I don't see a problem with making this configurable, but I don't understand why you need it if you need the old metric names. IIUC, when compatible_mode is true, the exporter uses the old names. And at the moment in Alloy it is always true? Do you mean that you need to use the new metric names?

docs/sources/reference/components/prometheus/prometheus.exporter.mongodb.md Outdated Show resolved Hide resolved
docs/sources/reference/components/prometheus/prometheus.exporter.mongodb.md Outdated Show resolved Hide resolved
docs/sources/reference/components/prometheus/prometheus.exporter.mongodb.md Outdated Show resolved Hide resolved
lomobot and others added 3 commits February 11, 2025 11:06
@lomobot @ptodev
Update docs/sources/reference/components/prometheus/prometheus.export…
accb4de 
…er.mongodb.md

Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
@lomobot @ptodev
Update docs/sources/reference/components/prometheus/prometheus.export…
8c7f2a3 
…er.mongodb.md

Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
@lomobot @ptodev
Update docs/sources/reference/components/prometheus/prometheus.export…
bea0033 
…er.mongodb.md

Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
@lomobot
Copy link
Author
lomobot commented Feb 11, 2025

In my usecase i need to enable --compatible-mode flag for mongodb_exporter to get old metrics naming.

@lomobot I don't see a problem with making this configurable, but I don't understand why you need it if you need the old metric names. IIUC, when compatible_mode is true, the exporter uses the old names. And at the moment in Alloy it is always true? Do you mean that you need to use the new metric names?

Hi! Yes, the defenition of my first issue was incorrect. Current goal of this PR is to add parameterisation for this option.

@lomobot lomobot requested a review from ptodev February 12, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell clayton-cornell left review comments

@ptodev ptodev Awaiting requested review from ptodev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an argument to prometheus.exporter.mongodb that activates flag "--compatible-mode" in mongodb_exporter
3 participants
@lomobot @clayton-cornell @ptodev
0