8000 fix(otelcol.exporter.prometheus): do not drop valid exemplars by github-vincent-miszczak · Pull Request #2602 · grafana/alloy · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(otelcol.exporter.prometheus): do not drop valid exemplars #2602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(otelcol.exporter.prometheus): do not drop valid exemplars #2602

wants to merge 2 commits into from

Conversation

github-vincent-miszczak
Copy link
@github-vincent-miszczak github-vincent-miszczak commented Feb 3, 2025 •
edited
Loading

PR Description

otelcol.exporter. Prometheus incorrectly rejects exemplars.
For instance, when using a histogram with exemplars, exemplars' timestamp is always lower than the regular samples timestamp.

See

Exemplars ordering has to be done regarding other exemplars, not regular samples.

Which issue(s) this PR fixes

Fixes #320

PR Checklist

  • CHANGELOG.md updated

@github-vincent-miszczak github-vincent-miszczak requested a review from a team as a code owner February 3, 2025 16:00
@CLAassistant
Copy link
CLAassistant commented Feb 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exemplars disappears during OpenTelemetry metrics to Prometheus metrics conversion
2 participants
@github-vincent-miszczak @CLAassistant
0