8000 feat: expose binary version in constants by adlotsof · Pull Request #2555 · grafana/alloy · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose binary version in constants #2555

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: expose binary version in constants #2555

wants to merge 5 commits into from
+76 −31

Conversation

adlotsof
Copy link
Contributor
@adlotsof adlotsof commented Jan 29, 2025 •
edited
Loading

PR Description

Which issue(s) this PR fixes

#2544

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added

@adlotsof adlotsof requested review from clayton-cornell and a team as code owners January 29, 2025 07:39
@mattdurham
Copy link
Collaborator

Kicked off the build, the name may need some adjustment. ie version vs build_version vs other. Thank you for the PR!

@mattdurham
Copy link
Collaborator

Looks like the conflicts need to be resolved before the build will start.

@adlotsof adlotsof force-pushed the ts/add_version_to_constants branch from 677d370 to 02f90a0 Compare January 29, 2025 15:47
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jan 30, 2025
@adlotsof @clayton-cornell
Update docs/sources/reference/stdlib/constants.md
dc80291 
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@adlotsof @dehaansa
Update syntax/internal/stdlib/constants.go
776e0a8 
Co-authored-by: Sam DeHaan <dehaansa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehaansa dehaansa dehaansa left review comments

@clayton-cornell clayton-cornell clayton-cornell left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adlotsof @mattdurham @dehaansa @clayton-cornell
0