Fix ICE candidate parsing #412
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update validation from len(parts) >= 10 to len(parts) >= 8 - Add support for standard RFC 5245 ICE candidates - Include real examples and RFC compliance in comments - Tested with actual host candidates: candidate:0 1 UDP 2122187007 192.168.1.52 38846 typ host
29856af to
3077f0a
Compare
|
I've stumble upon this issue too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
webrtc_connection_mixin.pyfix ICE candidate validation from len(parts) >= 10tolen(parts) >= 8to comply with RFC 5245 Section 15.1.Resolves rejection of valid Host candidates (8 tokens) and Peer-Reflexive candidates when self-reflexive peers gather without optional attributes. RFC 5245