Add default tag #183
Add default tag #183
Conversation
|
This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days. |
|
I took a quick glance over this, nothing stands out to me. @zak905 I know it's been awhile, are you willing to update the PR with the latest base branch? |
57be419 to
62c85ed
Compare
|
@jaitaiwan done. thanks for looking into it. I am glad to see the project active again |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 83.23% 86.59% +3.35%
==========================================
Files 4 4
Lines 710 843 +133
==========================================
+ Hits 591 730 +139
+ Misses 103 96 -7
- Partials 16 17 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks so much for the contribution @zak905 - I hate to ask any more of you when this has already been in progress for so long, but is there any chance the tests could be updated to meet our coverage standards? I'll make a special note to watch out for this PR to get it in asap. |
|
Sure thing, I will look into it asap. Thanks. |
|
@AlexVulaj thanks again for looking into this. I have added more testing to cover the unreached code, it should be ok now hopefully |
|
@jaitaiwan I'm good with this, wanna give it a quick last glance and merge? |
|
All finished @zak905 , appreciate the contribution. |
|
Welcome. Thanks @AlexVulaj and @jaitaiwan. I have to admit that I thought that this will never get merged, especially after the Gorilla project got archived :) so I would say this a great twist. Hopefully this will make setting default values trivial - I am hoping to see also some similar functionality in the standard golang json package someday. By the way, do you think it's worth adding a README section about the |
|
Definitely, if you’re happy to make a contribution we’ll endeavour to look asap. |
|
thanks. Read me updated at: #209 |
|
@jaitaiwan is it possible to create a release for this changeset (and other changes that occured since v1.2.1) ? |
|
Definitely possible @zak905 |
|
awesome thanks |
**Summary of Changes** this is the implementation for the functionality described in gorilla#182 1. add support for an optional `default` tag to allow setting values when decoding in case no value is provided 2. limiting the `default` tag scope to only primitive types and their pointers as well (cherry picked from commit eda9c33)
**Summary of Changes** this is the implementation for the functionality described in gorilla#182 1. add support for an optional `default` tag to allow setting values when decoding in case no value is provided 2. limiting the `default` tag scope to only primitive types and their pointers as well (cherry picked from commit eda9c33)
Summary of Changes
this is the implementation for the functionality described in #182
defaulttag to allow setting values when decoding in case no value is provideddefaulttag scope to only primitive types and their pointers as well