Add support for zone sharing in DNS v2 #3286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
mandre
reviewed
Feb 3, 2025
|
It looks like go-apidiff picked up the changes from #3284 and now marks your PR as non-backward compatible. That would be a problem with our automation, and I suspect that we'll get the expected semver label if you rebase on main. Could you do that? |
added 2 commits
February 7, 2025 12:54
This commit introduces functionality to share and unshare DNS zones with other projects using the OpenStack DNS v2 API. The following changes are included: - Added `Share` and `Unshare` methods in `requests.go` to handle API calls. - Updated `results.go` to include parsing for share/unshare responses. - Enhanced `urls.go` to generate proper URLs for share-related operations. - Created unit tests in `requests_test.go` to validate `Share` and `Unshare`. These additions allow users to manage shared zones programmatically and align Gophercloud with the DNS v2 API capabilities.
fd6d1cb to
05687fb
Compare
|
@mandre Cheers for spotting that! Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces functionality to share and unshare DNS zones with other projects using the OpenStack DNS v2 API. The following changes are included:
ShareandUnsharemethods inrequests.goto handle API calls.results.goto include parsing for share/unshare responses.urls.goto generate proper URLs for share-related operations.requests_test.goto validateShareandUnshare.These additions allow users to manage shared zones programmatically and align Gophercloud with the DNS v2 API capabilities.
Fixes #3048
Links to the line numbers/files in the OpenStack source code that support the code in this PR: